Olivier Fourdan [Fri, 30 Oct 2015 16:38:25 +0000 (17:38 +0100)]
GtkWindow: Fix the shadow width logic
Previous commit
305b34a "GtkWindow: fix move/get position with CSD"
introduced a regression because some windows presumably use shadows but
actually don't, resulting in a negative offset being wrongly applied.
Problem is that get_shadow_width() would return non-zero shadows even
for windows that have no shadow, thus causing the negative offset.
Fix the logic in get_shadow_width() and gtk_window_should_use_csd() so
that get_shadow_width() returns accurate values.
Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=756618
Matthias Clasen [Tue, 3 Nov 2015 04:49:38 +0000 (23:49 -0500)]
Adwaita: Update menubar styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 3 Nov 2015 04:49:20 +0000 (23:49 -0500)]
menubar: Use an element name
Matthias Clasen [Tue, 3 Nov 2015 04:43:58 +0000 (23:43 -0500)]
Adwaita: Update menu item styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 3 Nov 2015 04:42:14 +0000 (23:42 -0500)]
menu item: Use CSS nodes
Use the element name menuitem for GtkMenuItem, GtkCheckMenuItem
and GtkRadioMenuItem. GtkSeparatorMenuItem gets the name separator.
Add a subnode with name arrow if a submenu is attached.
Give the radio and check menu items a subnode with name check or
radio.
Matthias Clasen [Tue, 3 Nov 2015 04:06:57 +0000 (23:06 -0500)]
check button: Match documented behavior
We were not actually adding the style classes that the
documentation is talking about, for the !draw-indicator case.
Fix that.
Matthias Clasen [Tue, 3 Nov 2015 03:20:04 +0000 (22:20 -0500)]
menu item: Remove an unused member
Nobody is reading or writing this field, so we can do without it.
Matthias Clasen [Tue, 3 Nov 2015 02:49:10 +0000 (21:49 -0500)]
menu: Fix up CSS node ordering
Keep the bottom arrow node at the end, where it belongs.
Matthias Clasen [Tue, 3 Nov 2015 02:40:40 +0000 (21:40 -0500)]
menu: Document CSS nodes
Matthias Clasen [Tue, 3 Nov 2015 02:34:14 +0000 (21:34 -0500)]
HighContrast: Update menu styling
Support the element names introduced in the previous commit.
Matthias Clasen [Tue, 3 Nov 2015 01:47:04 +0000 (20:47 -0500)]
Adwaita: Update menu styling
Support the element names introduced in the previous commit.
Matthias Clasen [Tue, 3 Nov 2015 01:45:46 +0000 (20:45 -0500)]
menu: Port to use css nodes
Use the element name menu for the main node, and use two subnodes
with name arrow and style classes .top and .bottom for the arrows
of scrolling menus.
Cosimo Cecchi [Tue, 3 Nov 2015 00:05:07 +0000 (16:05 -0800)]
menushell: don't call gtk_render_background()
GtkMenu and GtkMenuBar, the two implementations of GtkMenuShell in GTK,
already draw it.
Furthermore, rendering a background here will overdraw any rendering
that the subclass will do, such as arrows for scrolling menus.
Benjamin Otte [Mon, 2 Nov 2015 19:25:09 +0000 (20:25 +0100)]
inspector: Do not show transient nodes
This is kind of a hack the way it's implemented, but it's necessary
for performance to ignore transient nodes as they get created all the
time (via gtk_style_context_save()) and invalidate the whole treeview.
And that causes resizes and redrawing of the treeview and performance of
the inspector would go down the drain now that we display a larger part
of the node tree.
Benjamin Otte [Mon, 2 Nov 2015 19:16:23 +0000 (20:16 +0100)]
inspector: Always show full CSS node tree
Just select the node of the current widget whenever a new one gets
selected.
Benjamin Otte [Mon, 2 Nov 2015 16:04:39 +0000 (17:04 +0100)]
gdkrgba: Use %g instead of %.17g to print alpha
This way 0.3 isn't printed as 0.
29999999999999
Matthias Clasen [Mon, 2 Nov 2015 19:26:50 +0000 (14:26 -0500)]
HighContrast: Update combobox styling
Adapt to the changes in the previous commit.
Matthias Clasen [Mon, 2 Nov 2015 19:22:49 +0000 (14:22 -0500)]
Adwaita: Update combobox styling
Adapt to the changes in the previous commit. Some further fixes will
be necessary here.
Matthias Clasen [Mon, 2 Nov 2015 18:15:05 +0000 (13:15 -0500)]
combobox: Use element names
Use combobox as the element name for the main CSS nodes of
GtkComboBox and GtkComboBoxText. Add the .combo style class
to the button and entry. in a GtkComboBox or GtkComboBoxText.
Matthias Clasen [Mon, 2 Nov 2015 17:53:57 +0000 (12:53 -0500)]
popover: Document differentiating style classes
There's a lot of popover variations out there.
Matthias Clasen [Mon, 2 Nov 2015 17:51:00 +0000 (12:51 -0500)]
button: Mention differentiating style classes
There's a lot of button variations out there, lets document
the ones we know about.
Matthias Clasen [Mon, 2 Nov 2015 17:47:14 +0000 (12:47 -0500)]
HighContrast: Update magnifier styling
Adapt to changes in the previous commit.
Matthias Clasen [Mon, 2 Nov 2015 17:46:45 +0000 (12:46 -0500)]
Adwaita: Update magnifier styling
Adapt to changes in the previous commit.
Matthias Clasen [Mon, 2 Nov 2015 17:40:38 +0000 (12:40 -0500)]
entry, textview: Use a dedicated style class for magnifier
This will free up "osd" as an application-level style class,
and lets us style magnifiers differently.
Matthias Clasen [Mon, 2 Nov 2015 17:27:36 +0000 (12:27 -0500)]
file chooser button: Add a style class
Unfortunately, GtkFileChooserButton is different from the other
pickers in that it is not a button, but rather has a button.
We ignore the difference for styling purposes, and just add
a .file style class to the button.
Matthias Clasen [Mon, 2 Nov 2015 17:21:39 +0000 (12:21 -0500)]
Adwaita: Fix menu separators
These were inadvertedly broken by the element name conversion
for regular separators.
Cemil Azizoglu [Thu, 15 Oct 2015 17:11:36 +0000 (12:11 -0500)]
mir: Print hscroll and vscroll values when debugging.
Signed-off-by: William Hua <william.hua@canonical.com>
Benjamin Otte [Sun, 1 Nov 2015 15:45:11 +0000 (16:45 +0100)]
inspector: Track updates of node styles
When the CSS style of a node changes, we want to display the new values
in the inspector.
This for example allows to see how styles update on hover or during
animations.
Colomban Wendling [Sat, 31 Oct 2015 22:02:36 +0000 (23:02 +0100)]
cssnode: Fix style updating when the CSS node ID changes
Since
4ebb5781eaf332da3f8ce5ffb5ecc8668a56f118 ID has a specific value,
while it used to be the same as NAME. Thus, explicitly list ID as a
radical change just like NAME.
https://bugzilla.gnome.org/show_bug.cgi?id=757397
Colomban Wendling [Sun, 1 Nov 2015 01:31:53 +0000 (02:31 +0100)]
cssnode: Fix a typo leading to very poor cache hashing
Colomban Wendling [Sun, 1 Nov 2015 01:35:09 +0000 (02:35 +0100)]
gtkcontainer: Guard internal use of deprecated public API
Benjamin Otte [Sun, 1 Nov 2015 01:34:41 +0000 (02:34 +0100)]
inspector: Store the current node in the priv struct
Benjamin Otte [Sat, 31 Oct 2015 16:14:14 +0000 (17:14 +0100)]
inspector: Split out a function
Matthias Clasen [Sun, 1 Nov 2015 01:02:36 +0000 (21:02 -0400)]
toolpalette: Use element names
Give the GtkToolPalette and GtkToolItemGroup the element
names toolpalette and toolitemgroup.
Matthias Clasen [Sun, 1 Nov 2015 00:55:51 +0000 (20:55 -0400)]
HighContrast: Update toolbutton styling
Matthias Clasen [Sun, 1 Nov 2015 00:52:41 +0000 (20:52 -0400)]
Adwaita: Update tool button styling
Matthias Clasen [Sun, 1 Nov 2015 00:52:09 +0000 (20:52 -0400)]
tool button: Add an element name
Unsurprisingly, it is toolbutton.
Matthias Clasen [Sun, 1 Nov 2015 00:43:07 +0000 (20:43 -0400)]
HighContrast: Update toolbar styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sun, 1 Nov 2015 00:42:41 +0000 (20:42 -0400)]
Adwaita: Update toolbar styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sun, 1 Nov 2015 00:30:56 +0000 (20:30 -0400)]
toolbar: Use an element name instead of a style class
The element name is ... toolbar.
Matthias Clasen [Sun, 1 Nov 2015 00:30:03 +0000 (20:30 -0400)]
progress bar: Add CSS documentation
Matthias Clasen [Sun, 1 Nov 2015 00:24:46 +0000 (20:24 -0400)]
HighContrast: Update progressbar styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sun, 1 Nov 2015 00:24:19 +0000 (20:24 -0400)]
Adwaita: Update progressbar styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sun, 1 Nov 2015 00:20:13 +0000 (20:20 -0400)]
progressbar: Convert to CSS nodes
Use the element names progressbar and progress.
Matthias Clasen [Sat, 31 Oct 2015 23:23:47 +0000 (19:23 -0400)]
trivial formatting fix
Matthias Clasen [Sat, 31 Oct 2015 23:19:53 +0000 (19:19 -0400)]
Remove a duplicate include
Matthias Clasen [Sat, 31 Oct 2015 23:13:32 +0000 (19:13 -0400)]
Adwaita: Fix up color button styling
There was one forgotten instance of the GtkColorSwatch type name.
Matthias Clasen [Sat, 31 Oct 2015 23:11:18 +0000 (19:11 -0400)]
HighContrast: Update the frame styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sat, 31 Oct 2015 23:10:52 +0000 (19:10 -0400)]
Adwaita: Update frame styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sat, 31 Oct 2015 23:09:46 +0000 (19:09 -0400)]
frame: Use an element name instead of a style class
Unsurprisingly, the element name is ... frame.
Matthias Clasen [Sat, 31 Oct 2015 22:13:29 +0000 (18:13 -0400)]
Load settings.ini from all data dirs
An error in the loading function was making us load the file from
the first data dir repeatedly, instead.
https://bugzilla.gnome.org/show_bug.cgi?id=757377
Paolo Borelli [Thu, 29 Oct 2015 16:20:54 +0000 (17:20 +0100)]
win32: handle WM_DISPLAYCHANGE globally
Instead of handling WM_DISPLAYCHANGE on every GdkWindow, only handle
it on an ad-hoc hidden window we create when opening the display.
This has two reasons:
1) we want emit the display::size-changed signal even if there are no
gtk windows currently open
2) we want to emit the signal just once and not once for every window
https://bugzilla.gnome.org/show_bug.cgi?id=757324
Matthias Clasen [Sat, 31 Oct 2015 04:08:00 +0000 (00:08 -0400)]
model button: Propagate state
Propagate the state to the CSS node for the indicator.
Matthias Clasen [Sat, 31 Oct 2015 04:07:19 +0000 (00:07 -0400)]
inspector: Show CSS node state
This is useful when debugging state propagation issues between
CSS nodes.
Matthias Clasen [Sat, 31 Oct 2015 03:49:44 +0000 (23:49 -0400)]
HighContrast: adjust message dialog styling
Matthias Clasen [Sat, 31 Oct 2015 03:49:17 +0000 (23:49 -0400)]
adwaita: Adjust message dialog styling
Matthias Clasen [Sat, 31 Oct 2015 03:48:46 +0000 (23:48 -0400)]
message dialog: Use an element name
Matthias Clasen [Sat, 31 Oct 2015 02:16:18 +0000 (22:16 -0400)]
color editor: Redo the non-activatable color swatch
Use a .activatable style class on the color swatch and tie the
hover effect to it. The color editor simply removes this class
now to get an inert color swatch.
This is more flexible and lets us avoid referring to the
GtkColorEditor type in the theme.
Matthias Clasen [Sat, 31 Oct 2015 01:46:36 +0000 (21:46 -0400)]
HighContrast: Adapt to color swatch changes
This needs more work and simplification.
Matthias Clasen [Sat, 31 Oct 2015 01:44:19 +0000 (21:44 -0400)]
Adwaita: Adapt to color swatch changes
This needs more work and simplification.
Matthias Clasen [Sat, 31 Oct 2015 01:43:50 +0000 (21:43 -0400)]
swatch fixup
Matthias Clasen [Sat, 31 Oct 2015 01:29:46 +0000 (21:29 -0400)]
color swatch: Convert to CSS nodes
Convert GtkColorSwatch to use the two elements colorswatch and
image.
Matthias Clasen [Sat, 31 Oct 2015 01:00:01 +0000 (21:00 -0400)]
text view: Add css node docs
Matthias Clasen [Fri, 30 Oct 2015 23:58:11 +0000 (19:58 -0400)]
HighContrast: Update textview styling
Some updates to make text appear as usual.
Matthias Clasen [Fri, 30 Oct 2015 23:55:42 +0000 (19:55 -0400)]
Adwaita: Update textview styling
Some updates to make text appear as usual. The border windows
probably need some more work.
Matthias Clasen [Fri, 30 Oct 2015 23:49:02 +0000 (19:49 -0400)]
text view: Convert to CSS nodes
Use subnodes for the border windows, and add children to the right
subnodes.
Matthias Clasen [Fri, 30 Oct 2015 22:11:13 +0000 (18:11 -0400)]
text view: Set an element name
And it will be...drumroll...textview.
Matthias Clasen [Fri, 30 Oct 2015 21:44:36 +0000 (17:44 -0400)]
icon view: Add an element name
Not surprising anybody, I decided to call it iconview.
Matthias Clasen [Fri, 30 Oct 2015 21:38:04 +0000 (17:38 -0400)]
HighContrast: Adapt to changed treeview names
Matthias Clasen [Fri, 30 Oct 2015 21:37:32 +0000 (17:37 -0400)]
Adwaita: Adapt to changed treeview names
Matthias Clasen [Fri, 30 Oct 2015 21:25:43 +0000 (17:25 -0400)]
tree view: Rename and document element names
The names are now treeview and header.
Matthias Clasen [Fri, 30 Oct 2015 21:18:06 +0000 (17:18 -0400)]
HighContrast: Update font button styling
Use the new element name and style class.
Matthias Clasen [Fri, 30 Oct 2015 21:17:41 +0000 (17:17 -0400)]
Adwaita: Update font button styling
Use the new element name and style class.
Matthias Clasen [Fri, 30 Oct 2015 21:09:59 +0000 (17:09 -0400)]
font button: Add an element name
Give this GtkButton subclass element name button and style class .font.
Matthias Clasen [Fri, 30 Oct 2015 16:52:47 +0000 (12:52 -0400)]
HighContrast: Update paned styling
Adapt to the new element names.
Matthias Clasen [Fri, 30 Oct 2015 16:50:32 +0000 (12:50 -0400)]
Adwaita: Update paned styling
Adapt to the new element names in the previous commit.
This also adds back a selected state which gets used
for when the focus is placed on the separator with F8,
just so this functionality is not forgotten.
Matthias Clasen [Fri, 30 Oct 2015 16:44:24 +0000 (12:44 -0400)]
paned: Convert to CSS nodes
Add a subnode for the separator, and use it for drawing.
Piotr Drąg [Fri, 30 Oct 2015 18:52:41 +0000 (19:52 +0100)]
Updated POTFILES.in and POTFILES.skip
Matthias Clasen [Fri, 30 Oct 2015 18:51:41 +0000 (14:51 -0400)]
Update the generated css for the previous commit
Timm Bäder [Fri, 30 Oct 2015 14:08:18 +0000 (15:08 +0100)]
popover: Use element name
Pick "popover" and add .menu for popover menus
Georges Basile Stavracas Neto [Thu, 29 Oct 2015 12:14:57 +0000 (10:14 -0200)]
placesview: vertically align path labels
The current situation is somewhat sad, with the path
label totally misaligned throughout the rows.
This is fixed by using a size group for the path labels,
so they all have the same allocated size (with the max
of 15 chars). Also, instead of hiding the eject button,
set it child-invisible, so it is hidden and yet it's size
is allocated by GtkBox.
https://bugzilla.gnome.org/show_bug.cgi?id=757303
Lapo Calamandrei [Fri, 30 Oct 2015 12:17:52 +0000 (13:17 +0100)]
Adwaita: fix vertical switch styling
Lapo Calamandrei [Fri, 30 Oct 2015 11:53:44 +0000 (12:53 +0100)]
Adwaita: fix switch sizing
moving -GtkSwitch-slider-width and -GtkSwitch-slider-height from
the GtkSwitch selector to the * wildcard selector as other style
props.
Matthias Clasen [Fri, 30 Oct 2015 10:49:57 +0000 (06:49 -0400)]
inspector: Drop the style property list
Style properties are now shown for each CSS node in the
CSS node tab, so we don't need a separate per-widget tab
for this.
Matthias Clasen [Fri, 30 Oct 2015 10:37:27 +0000 (06:37 -0400)]
inspector: Drop the style classes list
Style classes can now be added/removed for each CSS node in
the CSS node tab, so we don't need a separate per-widget tab
for this.
Yosef Or Boczko [Fri, 30 Oct 2015 10:26:52 +0000 (12:26 +0200)]
Updated Hebrew translation
Matthias Clasen [Fri, 30 Oct 2015 05:21:13 +0000 (01:21 -0400)]
menu button: Revisit style class one more time
Use .popup, which is already in use elsewhere, fits better with
the other button differentiating style classes, and does not
interfere with menus.
Matthias Clasen [Fri, 30 Oct 2015 05:16:49 +0000 (01:16 -0400)]
HighContrast: Update color button styling
Adapt to the previous commit.
Matthias Clasen [Fri, 30 Oct 2015 05:16:26 +0000 (01:16 -0400)]
Adwaita: Update color button styling
Adapt to the previous commit.
Matthias Clasen [Fri, 30 Oct 2015 05:15:57 +0000 (01:15 -0400)]
color button: Add a style class
Add a .color style class to differentiate this button from the
normal ones.
Marek Černocký [Fri, 30 Oct 2015 06:12:33 +0000 (07:12 +0100)]
Updated Czech translation
Matthias Clasen [Fri, 30 Oct 2015 05:09:18 +0000 (01:09 -0400)]
HighContrast: Update headerbar styling
Adapt to the previous commit.
Matthias Clasen [Fri, 30 Oct 2015 05:08:30 +0000 (01:08 -0400)]
Adwaita: Update headerbar styling
Adapt to the previous commit.
Matthias Clasen [Fri, 30 Oct 2015 05:07:58 +0000 (01:07 -0400)]
headerbar: Use an element name instead of a style class
Use the element name headerbar.
Matthias Clasen [Fri, 30 Oct 2015 05:07:27 +0000 (01:07 -0400)]
Revisit menu button style
Change the style class to .menubutton, to avoid interference
from GtkMenu theming.
Matthias Clasen [Fri, 30 Oct 2015 04:54:37 +0000 (00:54 -0400)]
menu button: Add a style class
Add a .menu style class to differentiate menu buttons from normal
ones.
Matthias Clasen [Fri, 30 Oct 2015 04:51:13 +0000 (00:51 -0400)]
scale button: Add a style class
Add a .scale style class to differentiate scale buttons from normal
ones.
Matthias Clasen [Fri, 30 Oct 2015 04:50:48 +0000 (00:50 -0400)]
link button: Add a style class
Add a .link style class to differentiate link buttons from normal
buttons.
Matthias Clasen [Fri, 30 Oct 2015 04:38:43 +0000 (00:38 -0400)]
HighContrast: Updates for recent changes
This is bit of a grab-bag, it includes fixes for spin buttons,
entries, buttons.
Matthias Clasen [Fri, 30 Oct 2015 04:31:02 +0000 (00:31 -0400)]
Adwaita: Adapt to the button changes
The updates here cover the various button variants.